[
https://issues.apache.org/jira/browse/HBASE-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14238098#comment-14238098
]
Ted Yu commented on HBASE-12630:
--------------------------------
{code}
+ private Map<ConfigurationObserver, Integer>
trackConfigurationObserversException =
{code}
How about naming the above map configurationObserverExceptionTracker ?
{code}
+ + ") failed in updating the configuration continuosly for more than
" + maxRetries
{code}
Typo: continuosly
{code}
+ int maxRetries =
+
conf.getInt(HConstants.HBASE_CONFIGURATION_OBSERVER_MAX_EXCEPTION_RETRIES,
+
HConstants.HBASE_CONFIGURATION_OBSERVER_MAX_EXCEPTION_RETRIES_DEFAULT);
{code}
There is no need to retrieve the max retry count every time, right ?
{code}
+ public Map<ConfigurationObserver, Integer>
getTrackConfigurationObserversException() {
...
+ public void setTrackConfigurationObserversException(
{code}
Where are the above methods accessed ?
> Provide capability for dropping malfunctioning ConfigurationObserver
> automatically
> ----------------------------------------------------------------------------------
>
> Key: HBASE-12630
> URL: https://issues.apache.org/jira/browse/HBASE-12630
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ashish Singhi
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12630.patch
>
>
> Chatting with Manukranth, online config update feature should handle the case
> where certain ConfigurationObserver(s) constantly produce exception when
> notified of config update.
> We can handle such ConfigurationObserver by sidelining it after configurable
> number of exceptions seen from the ConfigurationObserver.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
