[
https://issues.apache.org/jira/browse/HBASE-12630?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Ashish Singhi updated HBASE-12630:
----------------------------------
Status: Patch Available (was: Open)
Thanks for the reviews [~tedyu]
bq. How about naming the above map configurationObserverExceptionTracker ?
Looks better. Addressed in v3.
bq. Typo: continuosly
Addressed in v3.
bq. There is no need to retrieve the max retry count every time, right ?
Yes. Addressed in v3.
bq. Where are the above methods accessed ?
Not used removed them in v3.
bq. Can you expand the following data structure to include count of failed
notifications ?
I did not won't to change the existing map structure. Instead changed
configurationObserverExceptionTracker from HashMap to WeakHashMap.
> Provide capability for dropping malfunctioning ConfigurationObserver
> automatically
> ----------------------------------------------------------------------------------
>
> Key: HBASE-12630
> URL: https://issues.apache.org/jira/browse/HBASE-12630
> Project: HBase
> Issue Type: Improvement
> Reporter: Ted Yu
> Assignee: Ashish Singhi
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12630-v2.patch, HBASE-12630-v3.patch,
> HBASE-12630.patch
>
>
> Chatting with Manukranth, online config update feature should handle the case
> where certain ConfigurationObserver(s) constantly produce exception when
> notified of config update.
> We can handle such ConfigurationObserver by sidelining it after configurable
> number of exceptions seen from the ConfigurationObserver.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
