[
https://issues.apache.org/jira/browse/HBASE-12652?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14239882#comment-14239882
]
Nick Dimiduk commented on HBASE-12652:
--------------------------------------
Looking good [~sduskis].
Can we rename this method getMetaTable? Seems it's signature changed recently,
so why not remove the 'H' from the name?
{noformat}
+ static Table getMetaHTable(final Connection connection)
{noformat}
I only see 1 javadoc warning, looks like it's
{noformat}
[WARNING]
/home/jenkins/jenkins-slave/workspace/PreCommit-HBASE-Build/hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java:68:
warning - @param argument "admin" is not a parameter name.
{noformat}
Checkstyle warnings, again cannot find the other:
MetaTableAccessor, Unused import - org.apache.hadoop.hbase.client.HConnection
+1, will clean these on commit
> Allow unmanaged connections in MetaTableAccessor
> ------------------------------------------------
>
> Key: HBASE-12652
> URL: https://issues.apache.org/jira/browse/HBASE-12652
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.0.0, 2.0.0
> Reporter: Solomon Duskis
> Assignee: Solomon Duskis
> Attachments: HBASE-12652.patch, HBASE-12652.patch, HBASE-12652B.patch
>
>
> Passing in an unmanaged connnection to MetaTableAccessor causes an exception.
> MetaTableAccessor should be able to use both unmanaged and managed
> connections.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)