[ 
https://issues.apache.org/jira/browse/HBASE-12665?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14240329#comment-14240329
 ] 

stack commented on HBASE-12665:
-------------------------------

It dumps all beans into stdout.  Hundreds of lines yes... the JMX output.  The 
emission was for standalone/unit test yes.  Just demo'ing it 'works'.

bq. What I liked about what we had before was that it was concise and contained 
mostly stuff I was interested in

What you interested in?  Metrics are spread around a number of beans.  Yes, a 
bunch of operations have histograms now. The output looks kinda useful when 
server crash is 'fatal' (minus perhaps runtime bean dumping classpath again).

Stdout is intentional, yes.  Could make a 'String' and then give that to 
logging system but seems a bit obnoxious when in a fatal state.

bq. Finally, it would be nice to get some description of what's being dumped. I 
was actually confused when I saw this part:

Let me fix.

Let me see if I can do an edit on the output.. do a few beans only.



> When aborting, dump metrics
> ---------------------------
>
>                 Key: HBASE-12665
>                 URL: https://issues.apache.org/jira/browse/HBASE-12665
>             Project: HBase
>          Issue Type: Bug
>          Components: Operability
>            Reporter: stack
>            Assignee: stack
>             Fix For: 1.0.0, 2.0.0, 0.98.9
>
>         Attachments: 0001-First-cut.patch, 
> 0001-HBASE-12665-When-aborting-dump-metrics.patch, 12665v3.txt
>
>
> We used to dump out all metrics when we were exiting on abort. Was of use 
> debugging why the abort.  We used to have this.  [~jdcryans] noticed it was 
> dropped by his brother [~eclark] over in HBASE-6410 "Move RegionServer 
> Metrics to metrics2" To stop the two brothers fighting I intervened with this 
> patch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to