[
https://issues.apache.org/jira/browse/HBASE-12644?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14242080#comment-14242080
]
Jerry He commented on HBASE-12644:
----------------------------------
Hi, [~anoop.hbase]
Thanks for the review.
It seems that if I don't have the above two refresh calls, some of the
Visibility unit tests fail sometimes. Sometimes they all pass. Manual testing
on a cluster is always fine.
I think there is a race condition that is surfaced by this patch, and happens
in unit test because of the tight time (both client and server) in the tests.
Still looking into it.
Also, I see you have the two fresh calls in
DefaultVisibilityLabelServiceImpl.init(). I thought there is no harm having
the fresh call in updateZk() as well so we don't need to wait for ZK event
processing.
> Visibility Labels: issue with storing super users in labels table
> -----------------------------------------------------------------
>
> Key: HBASE-12644
> URL: https://issues.apache.org/jira/browse/HBASE-12644
> Project: HBase
> Issue Type: Bug
> Components: security
> Affects Versions: 0.98.8, 0.99.2
> Reporter: Jerry He
> Assignee: Jerry He
> Fix For: 1.0.0, 0.98.10
>
> Attachments: HBASE-12644-master-v2.patch, HBASE-12644-master.patch
>
>
> Super users have all the permissions for ACL and Visibility labels.
> They are defined in hbase-site.xml.
> Currently in VisibilityController, we persist super user with their system
> permission in hbase:labels.
> This makes change in super user difficult.
> There are two issues:
> In the current DefaultVisibilityLabelServiceImpl.addSystemLabel, we only add
> super user when we initially create the 'system' label.
> No additional update after that even if super user changed. See code for
> details.
>
> Additionally, there is no mechanism to remove any super user from the labels
> table.
>
> We probably should not persist super users in the labels table.
> They are in hbase-site.xml and can just stay in labelsCache and used from
> labelsCache after retrieval by Visibility Controller.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
