[
https://issues.apache.org/jira/browse/HBASE-12645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246327#comment-14246327
]
stack commented on HBASE-12645:
-------------------------------
[~varun_saxena] Sorry.. should have explained. I ran the hadoopqa just to see
what tests would fail. Thought it might be input for you as you were debugging
failures.
On current patch, its great. A few questions. With this in place, after the
test suite completes, we are not writing to user homedir any more? Also, the
new flag is never doc'd. What is it supposed to do? (I'm not clear). Flag is
createRootDirIfExists This means, create root dir if it exists? But we don't
check existance when we use it. Should we?
178 + public Path getDefaultRootDirPath(boolean createIfExists) throws
IOException {
179 + if (false == createIfExists) {
180 + return getDataTestDirOnTestFS();
181 + } else {
182 + return setupNewDataTestDirOnTestFS();
183 + }
184 + }
nit: Usually the following is written as if(!createIfExists) rather than as
if (false == createIfExists) {
Would we not want this flag always set? Or some tests need it not set?
Thanks [~varun_saxena]
> HBaseTestingUtility is using ${$HOME} for rootDir
> -------------------------------------------------
>
> Key: HBASE-12645
> URL: https://issues.apache.org/jira/browse/HBASE-12645
> Project: HBase
> Issue Type: Test
> Components: test
> Affects Versions: 1.0.0
> Reporter: Nick Dimiduk
> Assignee: Varun Saxena
> Priority: Critical
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-12645.002.patch, HBASE-12645.003.patch,
> HBASE-12645.004.patch, HBASE-12645.004.patch, HBASE-12645.005.patch,
> HBASE-12645.patch
>
>
> I noticed this while running tests on branch-1
> {noformat}
> Tests run: 1, Failures: 0, Errors: 1, Skipped: 0, Time elapsed: 0.009 sec <<<
> FAILURE! - in
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits Time
> elapsed: 0.009 sec <<< ERROR!
> java.io.FileNotFoundException: Destination exists and is not a directory:
> /homes/hortonnd/hbase
> at
> org.apache.hadoop.fs.RawLocalFileSystem.mkdirs(RawLocalFileSystem.java:423)
> at
> org.apache.hadoop.fs.ChecksumFileSystem.mkdirs(ChecksumFileSystem.java:588)
> at
> org.apache.hadoop.hbase.HBaseTestingUtility.createRootDir(HBaseTestingUtility.java:1053)
> at
> org.apache.hadoop.hbase.regionserver.wal.TestReadOldRootAndMetaEdits.setupBeforeClass(TestReadOldRootAndMetaEdits.java:70)
> {noformat}
> Either the testing utility has a regression or there's a config regression in
> this test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
