[
https://issues.apache.org/jira/browse/HBASE-12686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14246929#comment-14246929
]
Andrew Purtell edited comment on HBASE-12686 at 12/15/14 6:14 PM:
------------------------------------------------------------------
The unit test (at least in the 0.98 patch) does not quite check for a fix for
the reported problem: "If there are any split failures then [...] block
balancing to happen forever until unless master is restarted". It checks if
there are no regions in transition after a split failure. Should we load up a
few regions on a minicluster, fail a split on one of them, then check the
master can balance? Or is it just sufficient to check there are no regions in
transition after a split failure?
Any chance the daughters may no longer be in transition at this point?:
{code}
1322 if
(regionStates.isRegionInTransition(hri_a.getEncodedName())) {
1323 regionOffline(hri_a);
1324 }
1325 if
(regionStates.isRegionInTransition(hri_b.getEncodedName())) {
1326 regionOffline(hri_b);
1327 }
{code}
Just wondering why this change should not always offline the daughters.
was (Author: apurtell):
The unit test (at least in the 0.98 patch) does not quite check for a fix for
the reported problem: "If there are any split failures then [...] block
balancing to happen forever until unless master is restarted". It checks if
there are no regions in transition after a split failure. Should we load up a
few regions on a minicluster, fail a split on one of them, then check the
master can balance? Or is it just sufficient to check there are no regions in
transition after a split failure?
Any chance the daughters may no longer be in transition at this point?:
{code}
1322 if
(regionStates.isRegionInTransition(hri_a.getEncodedName())) {
1323 regionOffline(hri_a);
1324 }
1325 if
(regionStates.isRegionInTransition(hri_b.getEncodedName())) {
1326 regionOffline(hri_b);
1327 }
{code}
> Failures in split before PONR not clearing the daughter regions from regions
> in transition during rollback
> ----------------------------------------------------------------------------------------------------------
>
> Key: HBASE-12686
> URL: https://issues.apache.org/jira/browse/HBASE-12686
> Project: HBase
> Issue Type: Bug
> Components: Region Assignment
> Affects Versions: 0.98.9
> Reporter: Rajeshbabu Chintaguntla
> Assignee: Vandana Ayyalasomayajula
> Priority: Blocker
> Fix For: 1.0.0, 0.98.9
>
> Attachments: HBASE-12686-98.patch, HBASE-12686-branch-1.patch
>
>
> If there are any split failures then the both daughter regions left in
> SPLITTING_NEW transition even after rollback, which will block balancing to
> happen forever until unless master is restarted.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
