[ 
https://issues.apache.org/jira/browse/HBASE-12712?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251295#comment-14251295
 ] 

Hadoop QA commented on HBASE-12712:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12687977/compact.diff
  against master branch at commit 83e4bfaf73e1c7db16835b20c4f996adde30054a.
  ATTACHMENT ID: 12687977

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include 
any new or modified tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12131//console

This message is automatically generated.

> skipLargeFiles in minor compact but not in major compact
> --------------------------------------------------------
>
>                 Key: HBASE-12712
>                 URL: https://issues.apache.org/jira/browse/HBASE-12712
>             Project: HBase
>          Issue Type: New Feature
>          Components: Compaction
>    Affects Versions: 0.98.6
>            Reporter: Liu Junhong
>              Labels: newbie, patch
>             Fix For: 0.98.6
>
>         Attachments: compact.diff
>
>   Original Estimate: 72h
>  Remaining Estimate: 72h
>
> Here is my case. After repeatedly minor compaction, the size of storefile is 
> very large. Compaction with large storefile will waste much bandwidth, so i 
> use the “hbase.hstore.compaction.max.size” to skip this case. But after use 
> this config, i find that major compaction will be skipped forever when i read 
> the source code and the deletes and muti-versions data my waste storage. So i 
> had to modify the code. 
> Now i'm try to submit my patch.But my patch is not perfect. I think there 
> should be an other config to determine if the large size storefile should 
> join major compaction in HColumnDescriptor.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to