[ 
https://issues.apache.org/jira/browse/HBASE-12715?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14251579#comment-14251579
 ] 

zhangduo commented on HBASE-12715:
----------------------------------

Seems that HLogKey does not have a getRegionName method...
So should we use encodedRegionName when doing regionServerReport? 

And it is hard to write a testcase because we skip edits everywhere. It does 
not impact correctness, only impacts MTTR.

> Should pass regionName to HRegionServer.getLastSequenceId instead of 
> encodedRegionName
> --------------------------------------------------------------------------------------
>
>                 Key: HBASE-12715
>                 URL: https://issues.apache.org/jira/browse/HBASE-12715
>             Project: HBase
>          Issue Type: Bug
>          Components: wal
>    Affects Versions: 0.98.9
>            Reporter: zhangduo
>
> When addressing HBASE-12405 I found that LastSequenceId.getLastSequenceId(it 
> is renamed in master branch, doesn't matter) always returns -1, then I found 
> that we use encodedRegionName when calling this method. But when we doing 
> regionServerReport, we use regionName to report to HMaster(see the code in 
> HRegionServer.createRegionLoad). 
> We need to fix this, as seems we will disable distributed log replay in 0.98 
> by default?



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to