[
https://issues.apache.org/jira/browse/HBASE-12711?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14252401#comment-14252401
]
Srikanth Srungarapu commented on HBASE-12711:
---------------------------------------------
So, the thing here is in ThriftHttpServlet class:
{code}
public ThriftHttpServlet(TProcessor processor, TProtocolFactory protocolFactory,
UserGroupInformation realUser, Configuration conf,
ThriftServerRunner.HBaseHandler
hbaseHandler, boolean securityEnabled, boolean doAsEnabled) {
super(processor, protocolFactory);
this.realUser = realUser;
this.conf = conf;
this.hbaseHandler = hbaseHandler;
this.securityEnabled = securityEnabled;
this.doAsEnabled = doAsEnabled;
}
{code}
Findbug is unhappy about me using realUser, conf and hbaseHandler as they are
not implementing Serializable. The code is more or less inspired from [this
servlet|https://github.com/apache/hive/blob/trunk/service/src/java/org/apache/hive/service/cli/thrift/ThriftHttpServlet.java]
implementation in hive. You have any suggestions?
> Fix new findbugs warnings in hbase-thrift module
> ------------------------------------------------
>
> Key: HBASE-12711
> URL: https://issues.apache.org/jira/browse/HBASE-12711
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Srikanth Srungarapu
> Priority: Minor
> Attachments: HBASE-12711.patch
>
>
> From
> https://builds.apache.org/job/PreCommit-HBASE-Build/12121/artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
> , there were 5 findbugs warnings introduced.
> This issue fixes the new warnings.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
