[ 
https://issues.apache.org/jira/browse/HBASE-12684?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14253602#comment-14253602
 ] 

stack commented on HBASE-12684:
-------------------------------

You are getting close (smile).  Feel free to use hadoopqa to test your stuff; 
it is a little erratic so good at turning up issues.

Thanks for addressing the findbugs issue. Your patches are going to be big so 
good to stay on point if you can -- as much as possible (hard for me to tell 
you to do this since I am not good at it myself)

bq. That was my original thought. But I am now moving it to RpcClient interface 
as a constant since it is so basic to the HBase RPC protocol.

Makes sense.

When it passes all unit tests here, I'll take it for a run and try and get some 
perf numbers.



> Add new AsyncRpcClient
> ----------------------
>
>                 Key: HBASE-12684
>                 URL: https://issues.apache.org/jira/browse/HBASE-12684
>             Project: HBase
>          Issue Type: Improvement
>          Components: Client
>            Reporter: Jurriaan Mous
>            Assignee: Jurriaan Mous
>         Attachments: HBASE-12684-v1.patch, HBASE-12684-v2.patch, 
> HBASE-12684-v3.patch, HBASE-12684-v4.patch, HBASE-12684-v5.patch, 
> HBASE-12684-v6.patch, HBASE-12684.patch
>
>
> With the changes in HBASE-12597 it is possible to add new RpcClients. This 
> issue is about adding a new Async RpcClient which would enable HBase to do 
> non blocking protobuf service communication.
> Besides delivering a new AsyncRpcClient I would also like to ask the question 
> what it would take to replace the current RpcClient? This would enable to 
> simplify async code in some next issues.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to