[
https://issues.apache.org/jira/browse/HBASE-12620?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14255499#comment-14255499
]
Hadoop QA commented on HBASE-12620:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12688605/HBASE-12620_1.patch
against master branch at commit d9f25e30a1044caf9caaca047f954548c2ea8389.
ATTACHMENT ID: 12688605
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+0 tests included{color}. The patch appears to be a
documentation patch that doesn't require tests.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:red}-1 lineLengths{color}. The patch introduces the following lines
longer than 100:
+ <para> As mentioned in the above sections, the interface
<code>VisibilityLabelService</code> could
+ be used to implement the way the visibility expressions can be
stored in the cells. When we have clusters
+ with replication we also require that the visibility expressions
are also replicated to the peer cluster.
+ Take the case where the
<code>DefaultVisibilityLabelServiceImpl</code> is used as the implementation for
+ <code>VisibilityLabelService</code>. All the visibility expression
are converted to the corresponding
+ ordinal based expression based on the ordinals for each visibility
label stored in the labels table. This
+ would mean that during replication the cells with visibility would
also be replicated with ordinal based
+ expression. In the peer cluster, we may not have the same labels
table with the same ordinal mapping for
+ the visibility labels. In that case the ordinals in the replicated
cell does not make sense.
+ Hence it would be better if the replication happens with the
visibility expression as strings.
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12179//console
This message is automatically generated.
> Add HBASE-11639 related items to Ref Guide
> ------------------------------------------
>
> Key: HBASE-12620
> URL: https://issues.apache.org/jira/browse/HBASE-12620
> Project: HBase
> Issue Type: Improvement
> Components: documentation
> Reporter: ramkrishna.s.vasudevan
> Assignee: ramkrishna.s.vasudevan
> Fix For: 2.0.0, 1.1.0
>
> Attachments: HBASE-12620.patch, HBASE-12620_1.patch
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
