[
https://issues.apache.org/jira/browse/HBASE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14258011#comment-14258011
]
Rishit Shroff commented on HBASE-12752:
---------------------------------------
In a quorum, machines are known by host and port only; there is no
consideration of startcode. Thats ok? As far as a quorum client is concerned,
as long as same host and port, it will host same regions? (maybe that is the
case currently and thats fine but later, we might want to revisit?)
bq. Within a Quorum, a host and port should be good enough to uniquely identify
the member. startcode should not matter. We can surely revisit this later.
Is the compare in AbstractPeerManager (and in QuorumInfo ) going to be ok?
(Where we compare ServerName?) We sure it is always going to be NON_STARTCODE?
If so, fine. Might want to add a comment to that effect on commit.
bq. Yeah, the start code should always be NON_STARTCODE
Move to ServerName is going to better if though it not exactly the right fit
since HServerAddress was doing DNS lookups under the floorboards.
bq. I agree
Might want to change name of this method:
public ServerName getServerAddress() {
and ditto
public static ServerName getHRegionServerAddress(
bq. Done
[~stack] Ideally, we need only host+port for the consensus module. I was
tempted to use the HostAndPort from guava, but then I decided to remain in-sync
with HBase usage. Hence, the patch has NON_STARTCODE usage everywhere. If folks
are fine, I can send out a patch to change to HostAndPort.
Thanks,
Rishit
> Move from HServerAddress (0.89-fb) to ServerName in hbase-consensus module
> --------------------------------------------------------------------------
>
> Key: HBASE-12752
> URL: https://issues.apache.org/jira/browse/HBASE-12752
> Project: HBase
> Issue Type: Sub-task
> Components: hbase
> Affects Versions: HBASE-12259
> Reporter: Rishit Shroff
> Assignee: Rishit Shroff
> Priority: Minor
> Fix For: HBASE-12259
>
> Attachments:
> 0001-HBASE-12752-Get-rid-of-HServerAddress-from-hbase-con.patch
>
>
> 0.89-fb uses HServerAddress and so does hbase-consensus. The trunk has moved
> to ServerName and we need to migrate from HServerAddress to ServerName.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
