[ 
https://issues.apache.org/jira/browse/HBASE-3130?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105817#comment-13105817
 ] 

Lars Hofhansl commented on HBASE-3130:
--------------------------------------

+1

I think the patch is nice because it
o Keeps retrying logic in ReplicationSource
o Removes handling KeeperExceptions from ReplicationSource
o Has ReplicationPeer manage its watcher
o Now the zoo keeper failure handling is in ReplicationZookeeper

Nit: You could use Collections.emptyList() instead of new ArrayList<String>(0), 
and then just fall through to the set- and return getRegionServers.


> [replication] ReplicationSource can't recover from session expired on remote 
> clusters
> -------------------------------------------------------------------------------------
>
>                 Key: HBASE-3130
>                 URL: https://issues.apache.org/jira/browse/HBASE-3130
>             Project: HBase
>          Issue Type: Bug
>          Components: replication
>    Affects Versions: 0.92.0
>            Reporter: Jean-Daniel Cryans
>            Assignee: Chris Trezzo
>             Fix For: 0.92.0
>
>         Attachments: 3130-v2.txt, 3130.txt
>
>
> Currently ReplicationSource cannot recover when its zookeeper connection to 
> its remote cluster expires. HLogs are still being tracked, but a cluster 
> restart is required to continue replication (or a rolling restart).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to