[
https://issues.apache.org/jira/browse/HBASE-4258?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105842#comment-13105842
]
Ted Yu commented on HBASE-4258:
-------------------------------
Should metrics.blockCacheFree be called metrics.blockCacheFreeSize ?
For:
{code}
+ DoubleBlockCache castedCache = (DoubleBlockCache) blockCache;
{code}
We should either call it castCache, or better yet, doubleBlockCache.
See http://wiki.answers.com/Q/Past_tense_of_cast
Overall, patch looks good.
Mind sharing some screenshot(s) of the new metrics, Li ?
> Metrics panel for the Off Heap Cache
> ------------------------------------
>
> Key: HBASE-4258
> URL: https://issues.apache.org/jira/browse/HBASE-4258
> Project: HBase
> Issue Type: Sub-task
> Reporter: Li Pi
> Assignee: Li Pi
> Priority: Minor
> Fix For: 0.94.0
>
> Attachments: hbase-4258v1.txt
>
>
> Currently, stats and configuration are handled by logs/an xml file,
> respectively. There should be a better and more intuitive graphical interface
> for this.
> We could also add metrics to the RS metrics page.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
