[
https://issues.apache.org/jira/browse/HBASE-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14259580#comment-14259580
]
stack commented on HBASE-8329:
------------------------------
Thanks for picking this up again [~Apache9] and for posting numbers.
Looks like we need to be even more severe limiting compaction rates going by
your findings.
Did you read through the above issue to ensure your patch addresses previous
reviewers remarks on the patch?
Should the below finishCompaction be in a finally block so it is for sure
called even on exception?
289 peakCompactionsThrottle.finishCompaction(this.store.getRegionInfo()
290 .getRegionNameAsString(),
this.store.getFamily().getNameAsString());
This feature is off by default?
Should we emit warning when rate of compaction is high even if the feature is
not enabled?
Method name seems wrong here
2215 protected TimeOfDayTracker getOffPeakHours() {
2216 return this.offPeakHours; 2216 return this.offPeakHours;
2217 } 2217 }
Do you have to let this out at all ? For tests maybe?
Would be good to have descriptions on these
59 public static final String HBASE_HSTORE_PEAK_COMPACTION_SPEED_ALLOWED
=
60 "hbase.regionserver.compaction.peak.maxspeed";
61 public static final String
HBASE_HSTORE_PEAK_COMPACTION_SPEED_CHECK_INTERVAL =
62 "hbase.regionserver.compaction.speed.check.interval";
... so an operator could have a clue on what they do.
The means of throttling are coarse here but we can improve in later patches.
Thanks [~Apache9]
> Limit compaction speed
> ----------------------
>
> Key: HBASE-8329
> URL: https://issues.apache.org/jira/browse/HBASE-8329
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
> Reporter: binlijin
> Assignee: Sergey Shelukhin
> Fix For: 2.0.0, 1.1.0
>
> Attachments: HBASE-8329-10.patch, HBASE-8329-11.patch,
> HBASE-8329-12.patch, HBASE-8329-2-trunk.patch, HBASE-8329-3-trunk.patch,
> HBASE-8329-4-trunk.patch, HBASE-8329-5-trunk.patch, HBASE-8329-6-trunk.patch,
> HBASE-8329-7-trunk.patch, HBASE-8329-8-trunk.patch, HBASE-8329-9-trunk.patch,
> HBASE-8329-trunk.patch
>
>
> There is no speed or resource limit for compaction，I think we should add this
> feature especially when request burst.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
