[
https://issues.apache.org/jira/browse/HBASE-12752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14260332#comment-14260332
]
Rishit Shroff commented on HBASE-12752:
---------------------------------------
[~stack] Thanks for the review. I have addressed the review comments and
uploaded the new patch.
In below, you are worried the string may not be correctly formatted? Is that
why you go from string and back to string again?
179 HostAndPort leaderAddr = HostAndPort.fromString(leaderAddrString);
180 leader = agentMap.get(leaderAddr.toString());
bq. Done
You do sam ein QuorumThriftClientAgent
bq. Yeah, I need to create the InetSocketAddress object and hence need the
address and port separately. Therefore storing it in HostAndPort and then using
toString() for logging.
QuorumThriftClientCLI and AbstractPeerManager add imports that are not used?
bq. Done
+1 on patch. Above nits can be addressed on commit.
> Move from HServerAddress (0.89-fb) to HostAndPort in hbase-consensus module
> ---------------------------------------------------------------------------
>
> Key: HBASE-12752
> URL: https://issues.apache.org/jira/browse/HBASE-12752
> Project: HBase
> Issue Type: Sub-task
> Components: hbase
> Affects Versions: HBASE-12259
> Reporter: Rishit Shroff
> Assignee: Rishit Shroff
> Priority: Minor
> Fix For: HBASE-12259
>
> Attachments: 0001-Replace-HServerAddress-with-HostAndPort-1.patch,
> 0001-Replace-HServerAddress-with-HostAndPort.patch
>
>
> 0.89-fb uses HServerAddress and so does hbase-consensus. The trunk has moved
> to ServerName and we need to migrate from HServerAddress to ServerName.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
