[
https://issues.apache.org/jira/browse/HBASE-12748?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264145#comment-14264145
]
Andrew Purtell commented on HBASE-12748:
----------------------------------------
Sorry for the delay, I was out for the holidays.
The new patch looks ok. Just a couple of minor updates:
- Fix whitespace to conform with conventions of the rest of the code. See
http://hbase.apache.org/book/developing.html#common.patch.feedback
- Please add Javadoc for 'coprocessorList' explaining it's role.
> RegionCoprocessorHost.execOperation creates too many iterator objects
> ---------------------------------------------------------------------
>
> Key: HBASE-12748
> URL: https://issues.apache.org/jira/browse/HBASE-12748
> Project: HBase
> Issue Type: Sub-task
> Affects Versions: 0.94.25, 0.98.9
> Reporter: Vladimir Rodionov
> Assignee: Vladimir Rodionov
> Fix For: 1.0.0, 2.0.0, 0.98.10, 0.94.27
>
> Attachments: HBase-12748.patch
>
>
> This is typical pattern of enhanced for ... loop usage in a hot code path.
> For every HBase operation it instantiates iterator for coprocessor list
> twice.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
