[
https://issues.apache.org/jira/browse/HBASE-12779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14264231#comment-14264231
]
Lars Hofhansl edited comment on HBASE-12779 at 1/5/15 6:43 AM:
---------------------------------------------------------------
Hmm... So while testing the metrics I find we already have this as a region
server metric:
{noformat}
"splitTime_num_ops" : 1,
"splitTime_min" : 261,
"splitTime_max" : 261,
"splitTime_mean" : 261.0,
"splitTime_median" : 261.0,
"splitTime_75th_percentile" : 261.0,
"splitTime_95th_percentile" : 261.0,
"splitTime_99th_percentile" : 261.0
{noformat}
While perhaps not entirely intuitive we already have the number of splits in
{{splitTime_num_ops}}, which acts just as a counter. That counter is increased
whether the split was successful or not. So, not sure whether this patch is
going to add much.
Maybe the splitTime histogram metric should instead be more prominently
explained in the book...?
was (Author: lhofhansl):
Hmm... So while testing the metrics I find we already have this as a region
server metric:
{noformat}
"splitTime_num_ops" : 1,
"splitTime_min" : 261,
"splitTime_max" : 261,
"splitTime_mean" : 261.0,
"splitTime_median" : 261.0,
"splitTime_75th_percentile" : 261.0,
"splitTime_95th_percentile" : 261.0,
"splitTime_99th_percentile" : 261.0
{noformat}
While perhaps not entirely intuitive we already have the number of the
successful splits at least in {{splitTime_num_ops}}, which acts just as a
counter. That counter is increased whether the split was successful or not. So,
not sure whether this patch is going to add much.
Maybe the splitTime histogram metric should instead be more prominently
explained in the book...?
> SplitTransaction: Add metrics
> -----------------------------
>
> Key: HBASE-12779
> URL: https://issues.apache.org/jira/browse/HBASE-12779
> Project: HBase
> Issue Type: Sub-task
> Reporter: Lars Hofhansl
> Fix For: 2.0.0, 0.98.10, 1.0.1, 0.94.27
>
> Attachments: 12779-v2-0.98.txt, 12779-v2.txt, 12779.txt
>
>
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
