[ 
https://issues.apache.org/jira/browse/HBASE-12658?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Andrew Purtell updated HBASE-12658:
-----------------------------------
    Attachment: HBASE-12658-0.98.patch

Straightforward backport.

All changes are to private interfaces except where HBASE-11992 (backported int 
0.98.9) changed o.a.h.h.regionserver.MetricsSource to 
LimitedPrivate(REPLICATION). The changes of interest to MetricsSource are the 
removal of public static final Strings:
{code}
@@ -32,31 +32,13 @@ import org.apache.hadoop.hbase.util.EnvironmentEdgeManager;
 @InterfaceAudience.LimitedPrivate(HBaseInterfaceAudience.REPLICATION)
 public class MetricsSource {
 
-  public static final String SOURCE_SIZE_OF_LOG_QUEUE = 
"source.sizeOfLogQueue";
-  public static final String SOURCE_AGE_OF_LAST_SHIPPED_OP = 
"source.ageOfLastShippedOp";
-  public static final String SOURCE_LOG_EDITS_READ = "source.logEditsRead";
-  public static final String SOURCE_LOG_EDITS_FILTERED = 
"source.logEditsFiltered";
-  public static final String SOURCE_SHIPPED_BATCHES = "source.shippedBatches";
-  public static final String SOURCE_SHIPPED_KBS = "source.shippedKBs";
-  public static final String SOURCE_SHIPPED_OPS = "source.shippedOps";
-  public static final String SOURCE_LOG_READ_IN_BYTES = 
"source.logReadInBytes";
{code}
No method signatures are modified. I don't think this presents a problem but 
would like to highlight it for discussion. We could leave the string constants 
in place if so.

> Backport HBASE-12574 (Update replication metrics to not do so many map look 
> ups) to 0.98
> ----------------------------------------------------------------------------------------
>
>                 Key: HBASE-12658
>                 URL: https://issues.apache.org/jira/browse/HBASE-12658
>             Project: HBase
>          Issue Type: Task
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>             Fix For: 0.98.10
>
>         Attachments: HBASE-12658-0.98.patch
>
>
> Backport HBASE-12574 (Update replication metrics to not do so many map look 
> ups) to 0.98. Nice enhancement. It's a refactor so need to check for compat 
> issues there, and we need to add Hadoop 1 compat module support. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to