[ 
https://issues.apache.org/jira/browse/HBASE-2196?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Jean-Daniel Cryans updated HBASE-2196:
--------------------------------------

    Attachment: HBASE-2196-0.90.patch

Attaching a backport of this patch for 0.90

Doing this I learned a few things:

 - The addendum as provided isn't useful. It contains a revert of a previous 
addendum that wasn't posted as a patch, thus if you try to apply it it fails. 
Not a fan.

 - The addendum that wasn't posted should have removed the "OK!" comment here:
{code}
     try {
       admin.addPeer(ID_SECOND, KEY_SECOND);
-      fail();
     } catch (IllegalStateException iae) {
+      fail();
       // OK!
     }
{code}
It's ok or it's not? Had the addendum been posted, maybe someone could have 
catch this before.
 - I saw that the TestMultiSlaveReplication  test has this copied over from 
another test:
{code}
+    conf1.setStrings(CoprocessorHost.USER_REGION_COPROCESSOR_CONF_KEY,
+        
"org.apache.hadoop.hbase.replication.TestMasterReplication$CoprocessorCounter");
{code}
I was surprised the test worked even with that, until I figured it wasn't used 
in this test :)

> Support more than one slave cluster
> -----------------------------------
>
>                 Key: HBASE-2196
>                 URL: https://issues.apache.org/jira/browse/HBASE-2196
>             Project: HBase
>          Issue Type: Sub-task
>          Components: replication
>            Reporter: Jean-Daniel Cryans
>             Fix For: 0.92.0
>
>         Attachments: 2196-add.txt, 2196-v2.txt, 2196-v5.txt, 2196-v6.txt, 
> 2196.txt, HBASE-2196-0.90.patch, HBASE-2196-wip.patch
>
>
> Currently replication supports only 1 slave cluster, need to ability to add 
> more.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to