[
https://issues.apache.org/jira/browse/HBASE-8329?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14272514#comment-14272514
]
Ted Yu edited comment on HBASE-8329 at 1/10/15 2:21 PM:
--------------------------------------------------------
{code}
[email protected]
+public interface ThroughputController {
{code}
LimitedPrivate annotation should be used - same with the controllers which
implement the interface.
Please add javadoc for each method.
{code}
+ void cancelupThroughputTuner();
{code}
Remove 'up' in the name of the above method.
{code}
+ public void cancelupThroughputTuner() {
+ stop("Cancel Throughput Tuner");
{code}
Since cancel method calls stop(), is cancelThroughputTuner() needed ?
was (Author: [email protected]):
{code}
[email protected]
+public interface ThroughputController {
{code}
LimitedPrivate annotation should be used - same with the controllers which
implement the interface.
Please add javadoc for each method.
{code}
+ void cancelupThroughputTuner();
{code}
Remove 'up' in the name of the above method.
> Limit compaction speed
> ----------------------
>
> Key: HBASE-8329
> URL: https://issues.apache.org/jira/browse/HBASE-8329
> Project: HBase
> Issue Type: Improvement
> Components: Compaction
> Reporter: binlijin
> Assignee: zhangduo
> Fix For: 2.0.0, 1.1.0
>
> Attachments: HBASE-8329-10.patch, HBASE-8329-11.patch,
> HBASE-8329-12.patch, HBASE-8329-2-trunk.patch, HBASE-8329-3-trunk.patch,
> HBASE-8329-4-trunk.patch, HBASE-8329-5-trunk.patch, HBASE-8329-6-trunk.patch,
> HBASE-8329-7-trunk.patch, HBASE-8329-8-trunk.patch, HBASE-8329-9-trunk.patch,
> HBASE-8329-trunk.patch, HBASE-8329_13.patch
>
>
> There is no speed or resource limit for compaction，I think we should add this
> feature especially when request burst.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
