[
https://issues.apache.org/jira/browse/HBASE-4298?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107154#comment-13107154
]
Ted Yu commented on HBASE-4298:
-------------------------------
For nodeChildrenChanged(), please change the sentence for catch black of
IOException, it mentioned zk exception.
For ZooKeeperWatcher.java:
{code}
+ conf.get("zookeeper.znode.draining", "draining"));
{code}
I think a better name maybe "zookeeper.znode.draining.rs"
Can you write some unit tests for this feature ?
Please also share your experience from using this in your environment.
> Support to drain RS nodes through ZK
> ------------------------------------
>
> Key: HBASE-4298
> URL: https://issues.apache.org/jira/browse/HBASE-4298
> Project: HBase
> Issue Type: Improvement
> Components: master
> Affects Versions: 0.90.4
> Environment: all
> Reporter: Aravind Gottipati
> Priority: Critical
> Labels: patch
> Fix For: 0.92.0, 0.90.5
>
>
> HDFS currently has a way to exclude certain datanodes and prevent them from
> getting new blocks. HDFS goes one step further and even drains these nodes
> for you. This enhancement is a step in that direction.
> The idea is that we mark nodes in zookeeper as draining nodes. This means
> that they don't get any more new regions. These draining nodes look exactly
> the same as the corresponding nodes in /rs, except they live under /draining.
> Eventually, support for draining them can be added. I am submitting two
> patches for review - one for the 0.90 branch and one for trunk (in git).
> Here are the two patches
> 0.90 -
> https://github.com/aravind/hbase/commit/181041e72e7ffe6a4da6d82b431ef7f8c99e62d2
> trunk -
> https://github.com/aravind/hbase/commit/e127b25ae3b4034103b185d8380f3b7267bc67d5
> I have tested both these patches and they work as advertised.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
