[ 
https://issues.apache.org/jira/browse/HBASE-12833?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275222#comment-14275222
 ] 

Solomon Duskis commented on HBASE-12833:
----------------------------------------

A couple of comments on this:

1) the interface changes and the managed/unmanaged connection issues are 
separate concerns.
2) On the mailing list you said:  "Yes, the concept of connection caching, aka, 
managed connections are going away."

If managed connections are going away, then let's make them go away across the 
board.  If they're staying, then let's keep them and rework the interfaces to 
support managed connections as a first class citizen.  I only see disadvantages 
for inconsistency in this aspect.

That said, this can totally be something that I'm missing.  Do you see any 
advantages to keeping a mix of managed and unmanaged connections around?

> [shell] table.rb leaks connections
> ----------------------------------
>
>                 Key: HBASE-12833
>                 URL: https://issues.apache.org/jira/browse/HBASE-12833
>             Project: HBase
>          Issue Type: Bug
>          Components: shell
>    Affects Versions: 1.0.0, 2.0.0, 1.1.0
>            Reporter: Nick Dimiduk
>            Assignee: Solomon Duskis
>             Fix For: 1.0.0, 2.0.0, 1.1.0
>
>         Attachments: HBASE-12833.patch
>
>
> TestShell is erring out (timeout) consistently for me. Culprit is OOM cannot 
> create native thread. It looks to me like test_table.rb and hbase/table.rb 
> are made for leaking connections. table calls 
> ConnectionFactory.createConnection() for every table but provides no close() 
> method to clean it up. test_table creates a new table with every test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to