[
https://issues.apache.org/jira/browse/HBASE-12849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14275683#comment-14275683
]
Nick Dimiduk commented on HBASE-12849:
--------------------------------------
This should clean up after itself, call close for both the table and
connection. How about wrapping these changes with the new try-with-resource
syntax? Master needs the same correction.
+1 for cleanup on commit. Thanks [~tedyu].
> LoadIncrementalHFiles should use unmanaged connection in branch-1
> -----------------------------------------------------------------
>
> Key: HBASE-12849
> URL: https://issues.apache.org/jira/browse/HBASE-12849
> Project: HBase
> Issue Type: Bug
> Reporter: Ted Yu
> Assignee: Ted Yu
> Fix For: 1.1.0
>
> Attachments: 12849-1.1.patch
>
>
> From
> https://builds.apache.org/job/HBase-1.1/78/testReport/org.apache.hadoop.hbase.mapreduce/TestLoadIncrementalHFiles/testSimpleLoad/
> :
> {code}
> java.io.IOException: The connection has to be unmanaged.
> at
> org.apache.hadoop.hbase.client.ConnectionManager$HConnectionImplementation.getAdmin(ConnectionManager.java:715)
> at
> org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.doBulkLoad(LoadIncrementalHFiles.java:239)
> at
> org.apache.hadoop.hbase.mapreduce.LoadIncrementalHFiles.run(LoadIncrementalHFiles.java:936)
> at
> org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles.runTest(TestLoadIncrementalHFiles.java:255)
> at
> org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles.runTest(TestLoadIncrementalHFiles.java:229)
> at
> org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles.runTest(TestLoadIncrementalHFiles.java:216)
> at
> org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles.runTest(TestLoadIncrementalHFiles.java:206)
> at
> org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles.testSimpleLoad(TestLoadIncrementalHFiles.java:102)
> {code}
> LoadIncrementalHFiles should use unmanaged connection.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)