[
https://issues.apache.org/jira/browse/HBASE-11983?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276339#comment-14276339
]
Hudson commented on HBASE-11983:
--------------------------------
SUCCESS: Integrated in HBase-TRUNK #6020 (See
[https://builds.apache.org/job/HBase-TRUNK/6020/])
HBASE-11983 HRegion constructors should not create HLog (ndimiduk: rev
9b7f36b8cf521bcc01ac6476349a9d2f34be8bb3)
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegionInfo.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/client/TestIntraRowPagination.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsckRepair.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingTTL.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestDefaultCompactSelection.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestColumnPrefixFilter.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/encoding/TestPrefixTree.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanner.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/snapshot/RestoreSnapshotHelper.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/io/hfile/TestScannerSelectionUsingKeyRange.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestScanWithBloomError.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTable.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestDependentColumnFilter.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestColumnSeeking.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestPerColumnFamilyFlush.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestWALReplay.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/ModifyRegionUtils.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/wal/TestFSHLog.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/wal/WALFactory.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestKeepDeletes.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestGetClosestAtOrBefore.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestWideScanner.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestHRegion.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/util/TestMergeTool.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/util/HBaseFsck.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestRegionMergeTransaction.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestInvocationRecordFilter.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMultiColumnScanner.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestAtomicOperation.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestReversibleScanners.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestCoprocessorInterface.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestMinVersions.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestCase.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestFilter.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSplitTransaction.java
*
hbase-server/src/main/java/org/apache/hadoop/hbase/master/MasterFileSystem.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverScannerOpenHook.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestResettingCounters.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestSeekOptimizations.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/coprocessor/TestRegionObserverStacking.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/master/TestMasterFailover.java
* hbase-server/src/main/java/org/apache/hadoop/hbase/regionserver/HRegion.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/regionserver/TestJoinedScanners.java
*
hbase-server/src/test/java/org/apache/hadoop/hbase/filter/TestMultipleColumnPrefixFilter.java
* hbase-server/src/test/java/org/apache/hadoop/hbase/HBaseTestingUtility.java
> HRegion constructors should not create HLog
> --------------------------------------------
>
> Key: HBASE-11983
> URL: https://issues.apache.org/jira/browse/HBASE-11983
> Project: HBase
> Issue Type: Bug
> Components: wal
> Reporter: Enis Soztutar
> Assignee: Nick Dimiduk
> Labels: beginner
> Fix For: 2.0.0, 1.1.0
>
> Attachments: HBASE-11983.00-branch-1.patch, HBASE-11983.00.patch,
> HBASE-11983.01.patch, HBASE-11983.02.patch, HBASE-11983.03.patch,
> HBASE-11983.03.patch, HBASE-11983.04.patch, HBASE-11983.05.patch
>
>
> We should get rid of HRegion creating its own HLog. It should ALWAYS get the
> log from outside.
> I think this was added for unit tests, but we should refrain from such
> practice in the future (adding UT constructors always leads to weird and
> critical bugs down the road). See recent: HBASE-11982, HBASE-11654.
> Get rid of weird things like ignoreHLog:
> {code}
> /**
> * @param ignoreHLog - true to skip generate new hlog if it is null, mostly
> for createTable
> */
> public static HRegion createHRegion(final HRegionInfo info, final Path
> rootDir,
> final Configuration conf,
> final HTableDescriptor hTableDescriptor,
> final HLog hlog,
> final boolean initialize, final boolean
> ignoreHLog)
> {code}
> We can unify all the createXX and newXX methods and separate creating a
> region in the file system vs opening a region.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
