[ 
https://issues.apache.org/jira/browse/HBASE-12393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14276699#comment-14276699
 ] 

ChiaPing Tsai commented on HBASE-12393:
---------------------------------------

hi [~ndimiduk]. Thanks for the help. The new patch is vs master and it includes 
all changes. There are some error in the report, but they are caused by other 
Unit Test. What mistake did i make?Thanks.

> The regionserver web will throw exception if we disable block cache
> -------------------------------------------------------------------
>
>                 Key: HBASE-12393
>                 URL: https://issues.apache.org/jira/browse/HBASE-12393
>             Project: HBase
>          Issue Type: Bug
>          Components: regionserver, UI
>    Affects Versions: 0.98.7
>         Environment: ubuntu 12.04 64bits, hadoop-2.2.0, hbase-0.98.7-hadoop2
>            Reporter: ChiaPing Tsai
>            Assignee: ChiaPing Tsai
>            Priority: Minor
>             Fix For: 1.0.0, 2.0.0, 0.98.10, 1.1.0
>
>         Attachments: HBASE-12393-master.patch, HBASE-12393.patch
>
>
> The CacheConfig.getBlockCache() will return the null point when we set 
> hfile.block.cache.size to zero.
> The BlockCacheTmpl.jamon doesn't make a check on null blockcache.
> {code}
> <%if cacheConfig == null %>
> <p>CacheConfig is null</p>
> <%else>
> <table class="table table-striped">
>     <tr>
>         <th>Attribute</th>
>         <th>Value</th>
>         <th>Description</th>
>     </tr>
>     <tr>
>         <td>Size</td>
>         <td><% 
> StringUtils.humanReadableInt(cacheConfig.getBlockCache().size()) %></td>
>         <td>Total size of Block Cache (bytes)</td>
>     </tr>
>     <tr>
>         <td>Free</td>
>         <td><% 
> StringUtils.humanReadableInt(cacheConfig.getBlockCache().getFreeSize()) 
> %></td>
>         <td>Free space in Block Cache (bytes)</td>
>     </tr>
>     <tr>
>         <td>Count</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getBlockCount()) %></td>
>         <td>Number of blocks in Block Cache</td>
>     </tr>
>     <tr>
>         <td>Evicted</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getEvictedCount()) %></td>
>         <td>Number of blocks evicted</td>
>     </tr>
>     <tr>
>         <td>Evictions</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getEvictionCount()) %></td>
>         <td>Number of times an eviction occurred</td>
>     </tr>
>     <tr>
>         <td>Hits</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getHitCount()) %></td>
>         <td>Number requests that were cache hits</td>
>     </tr>
>     <tr>
>         <td>Hits Caching</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getHitCachingCount()) %></td>
>         <td>Cache hit block requests but only requests set to use Block 
> Cache</td>
>     </tr>
>     <tr>
>         <td>Misses</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getMissCount()) %></td>
>         <td>Number of requests that were cache misses</td>
>     </tr>
>     <tr>
>         <td>Misses Caching</td>
>         <td><% String.format("%,d", 
> cacheConfig.getBlockCache().getStats().getMissCount()) %></td>
>         <td>Block requests that were cache misses but only requests set to 
> use Block Cache</td>
>     </tr>
>     <tr>
>         <td>Hit Ratio</td>
>         <td><% String.format("%,.2f", 
> cacheConfig.getBlockCache().getStats().getHitRatio() * 100) %><% "%" %></td>
>         <td>Hit Count divided by total requests count</td>
>     </tr>
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to