[
https://issues.apache.org/jira/browse/HBASE-4282?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13107490#comment-13107490
]
stack commented on HBASE-4282:
------------------------------
If lastDeferredSeq is 0, does this also mean the feature not enabled? The
setting and clearing of this long is done inside a synchronized block? Patch
looks fine to me. This log message will get noisey? LOG.debug("Last deferred
seq ("+currentDeferredSeq+") cleared on sync()");... and same here: +
LOG.debug("Last deferred seq="+lastDeferredSeq);
> Potential data loss in retries of WAL close introduced in HBASE-4222
> --------------------------------------------------------------------
>
> Key: HBASE-4282
> URL: https://issues.apache.org/jira/browse/HBASE-4282
> Project: HBase
> Issue Type: Bug
> Reporter: Gary Helmling
> Assignee: Gary Helmling
> Priority: Blocker
> Fix For: 0.92.0, 0.90.5
>
> Attachments: HBASE-4282_trunk_prelim.patch
>
>
> The ability to ride over WAL close errors on log rolling added in HBASE-4222
> could lead to missing HLog entries if:
> * A table has DEFERRED_LOG_FLUSH=true
> * There are unflushed WALEdit entries for that table in the current
> SequenceFile writer buffer
> Since the writes were already acknowledged to the client, just ignoring the
> close error to allow for another log roll doesn't seem like the right thing
> to do here.
> We could easily flag this state and only ride over the close error if there
> aren't unflushed entries. This would bring the above condition back to the
> previous behavior of aborting the region server. However, aborting the
> region server in this state is still guaranteeing data loss. Is there
> anything we can do better in this case?
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
