[
https://issues.apache.org/jira/browse/HBASE-12808?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286354#comment-14286354
]
Dima Spivak commented on HBASE-12808:
-------------------------------------
Thanks for taking a look at this, guys. About to post a new patch for the
following:
- Following [~apurtell]'s experience, I've updated the script logic so that if,
after specifying --no-checkout, no packaged JARs (e.g. hbase-*.jar) are found
in either of the /1 or /2 directories, it will attempt to build them. I've
avoided catching cases where users forget to create the numbered directories
themselves since the usage message is pretty clear that they're needed.
- Added a GETOPT=${GETOPT:-/usr/bin/env getopt} line in the script and a note
in the header about specifying your own variant if a non-GNU getopt is on the
path for your machine.
- The script now does its work in dev-support/target/compatibility rather than
just just dev-support/compatibility for the reasons Sean pointed out above.
Moreover, this obviates the need for this patch to include a .gitignore since
the top-level one already ignores all /target directories.
- I'll open a separate JIRA around fixing RAT to respect the exclusion list for
dev-support.
- After this is committed, we can use HBASE-12556 to discuss how to incorporate
the tool into CI. I think you guys have convinced me that the benefits of
having it part of the test-patch process outweigh the costs.
> Use Java API Compliance Checker for binary/source compatibility
> ---------------------------------------------------------------
>
> Key: HBASE-12808
> URL: https://issues.apache.org/jira/browse/HBASE-12808
> Project: HBase
> Issue Type: Improvement
> Components: test
> Reporter: Dima Spivak
> Assignee: Dima Spivak
> Attachments: HBASE-12808_v1.patch, HBASE-12808_v2.patch,
> HBASE-12808_v3.patch
>
>
> Following [~busbey]'s suggestion in HBASE-12556, I've spent some time playing
> with the [Java API Compliance
> Checker|http://ispras.linuxbase.org/index.php/Java_API_Compliance_Checker]
> and think it would be a great addition to /dev-support. I propose that we use
> it to replace the JDiff wrappers we currently have there (since it does what
> JDiff does and more), and look into putting up automation at
> builds.apache.org to run the tool regularly (e.g. latest release of a
> particular branch vs. latest commit of that same branch).
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
