[ 
https://issues.apache.org/jira/browse/HBASE-12899?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14286476#comment-14286476
 ] 

Colin Patrick McCabe commented on HBASE-12899:
----------------------------------------------

thanks for the review, Nick.

HTrace-for-hbase isn't really deployed in production yet.  I would be surprised 
if anyone but a handful of devs had used this.  I think now is the right time 
to change the prefix so that we don't get conflicts between htrace and hbase 
configuration keys.

If we start with compatibility shims, we'll have to carry them around forever 
(speaking from Hadoop experience) and there's little benefit.  We only just got 
an HTrace release last week! :)

> HBase should prefix htrace configuration keys with "hbase.htrace" rather than 
> just "hbase."
> -------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12899
>                 URL: https://issues.apache.org/jira/browse/HBASE-12899
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 1.0.0
>            Reporter: Colin Patrick McCabe
>         Attachments: HBASE-12899.001.patch
>
>
> In Hadoop, we pass all configuration keys starting with "hadoop.htrace" to 
> htrace.  So "hadoop.htrace.sampler.fraction" gets passed to HTrace as 
> sampler.fraction, and so forth.
> For consistency, it seems like HBase should prefix htrace configuration keys 
> with "hbase.htrace" rather than just "hbase."



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to