[
https://issues.apache.org/jira/browse/HBASE-12898?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14288093#comment-14288093
]
Sean Busbey commented on HBASE-12898:
-------------------------------------
bq. Looks reasonable to me Sean Busbey... all look like stuff we depend on.
Only question is that in client pom, someone added guava as exclusion. It was
being transitively included I suppose when we didn't want it. You add it as
explicit dependency. I suppose we need it there?
We make use of it directly within hbase-client a few ways
{code}
hbase busbey$ grep -r "com.google.common" hbase-client/src/ | grep "import" |
wc -l
49
hbase busbey$ grep -h -r "com.google.common" hbase-client/src/ | grep "import"
| sort -u | wc -l
13
{code}
Most of it isn't annotations, so we can't just use it at compile time.
{code}
hbase busbey$ grep -r "com.google.common" hbase-client/src/ | grep "import" |
grep -v com.google.common.annotations | wc -l
32
hbase busbey$ grep -h -r "com.google.common" hbase-client/src/ | grep "import"
| grep -v com.google.common.annotations | sort -u | wc -l
12
{code}
> Add in used undeclared dependencies
> -----------------------------------
>
> Key: HBASE-12898
> URL: https://issues.apache.org/jira/browse/HBASE-12898
> Project: HBase
> Issue Type: Bug
> Components: build
> Affects Versions: 1.0.0, 0.98.9
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Blocker
> Fix For: 1.0.0, 2.0.0, 0.98.10, 1.1.0
>
> Attachments: HBASE-12898-0.98.1.patch.txt,
> HBASE-12898-0.98.2.patch.txt, HBASE-12898-branch-1.1.patch.txt,
> HBASE-12898.1.patch.txt
>
>
> I recently had a build fail because hbase-rest ran into some issue getting
> the transitive dependencies for hbase-server. The failure was because
> hbase-rest needs jetty-sslengine but was getting it transitively. looking at
> dependency:analyze, we have lots of places where we're doing this.
> Clean up cases where our pom doesn't list direct dependencies for modules.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
