[ 
https://issues.apache.org/jira/browse/HBASE-12909?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289505#comment-14289505
 ] 

stack commented on HBASE-12909:
-------------------------------

Patch looks good. More finesse than what was there before. Want me to check 
with https://github.com/saintstack/hbase-downstreamer? It was a means of faking 
a downstream app checking we pull in dependencies we need.

> Junit listed at compile scope instead of test
> ---------------------------------------------
>
>                 Key: HBASE-12909
>                 URL: https://issues.apache.org/jira/browse/HBASE-12909
>             Project: HBase
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 1.0.0
>            Reporter: Sean Busbey
>            Assignee: Sean Busbey
>             Fix For: 1.0.0, 2.0.0
>
>         Attachments: HBASE-12909.1.patch.txt
>
>
> Right now our top level pom lists junit as a dependency for every module in 
> the compile scope, which makes it subject to our compatibility promises.
> It should instead be test scope.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to