[ 
https://issues.apache.org/jira/browse/HBASE-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14295425#comment-14295425
 ] 

stack commented on HBASE-5954:
------------------------------

fsync every meta edit? I suppose that makes sense.  Something we've always 
wanted even.

Do we want to keep a syncCount and an fSyncCount?

It looks like

            currentSequence = updateHighestSyncedSequence(currentSequence);

highestSyncedSequence is the absolute highest, the highest for sync and fsync, 
which (I think) I follow.

The patch looks good. I can't see anything obviously wrong. Lets get it in.  As 
per [~busbey], need write up that this long-wanted facility is now available. 
Would be cool to get numbers but that can be post-commit too.



> Allow proper fsync support for HBase
> ------------------------------------
>
>                 Key: HBASE-5954
>                 URL: https://issues.apache.org/jira/browse/HBASE-5954
>             Project: HBase
>          Issue Type: Improvement
>          Components: HFile, wal
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: 5954-WIP-trunk.txt, 5954-WIP-v2-trunk.txt, 
> 5954-trunk-hdfs-trunk-v2.txt, 5954-trunk-hdfs-trunk-v3.txt, 
> 5954-trunk-hdfs-trunk-v4.txt, 5954-trunk-hdfs-trunk-v5.txt, 
> 5954-trunk-hdfs-trunk-v6.txt, 5954-trunk-hdfs-trunk.txt, hbase-hdfs-744.txt
>
>
> At least get recommendation into 0.96 doc and some numbers running w/ this 
> hdfs feature enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to