[ https://issues.apache.org/jira/browse/HBASE-11586?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14296593#comment-14296593 ]
hongyu bi commented on HBASE-11586: ----------------------------------- we just upgrade 0.98.6 from 0.94.15 , and I can't find the fs{read|write}ops/latency metrics, what about the new jira? many thanks > HFile's HDFS op latency sampling code is not used > ------------------------------------------------- > > Key: HBASE-11586 > URL: https://issues.apache.org/jira/browse/HBASE-11586 > Project: HBase > Issue Type: Bug > Affects Versions: 0.98.4 > Reporter: Andrew Purtell > Assignee: Andrew Purtell > Fix For: 0.99.0, 0.98.5, 2.0.0 > > Attachments: HBASE-11586.patch, HBASE-11586.patch > > > HFileReaderV2 calls HFile#offerReadLatency and HFileWriterV2 calls > HFile#offerWriteLatency but the samples are never retrieved. There are no > callers of HFile#getReadLatenciesNanos, HFile#getWriteLatenciesNanos, and > related. The three ArrayBlockingQueues we are using as sample buffers in > HFile will fill quickly and are never drained. > There are also no callers of HFile#getReadTimeMs or HFile#getWriteTimeMs, and > related, so we are incrementing a set of AtomicLong counters that will never > be read nor reset. > We are calling System.nanoTime in block read and write paths twice but not > utilizing the measurements. > We should hook this code back up to metrics or remove it. > We are also not using HFile#getChecksumFailuresCount anywhere but in some > unit test code. -- This message was sent by Atlassian JIRA (v6.3.4#6332)