[ 
https://issues.apache.org/jira/browse/HBASE-4450?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13109359#comment-13109359
 ] 

[email protected] commented on HBASE-4450:
------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/1998/
-----------------------------------------------------------

Review request for Michael Stack and Jonathan Gray.


Summary
-------

Test deliberately creates a table with blocksize = 1Byte (so that each KV is a 
block of its own).
The getData() calls all take a last argument which is the number of expected 
blocks read. Those numbers are the current baseline. I'll hope to submit 
patches for hbase-4433 & hbase-4434 in the next day or so, and at that time 
these counts should go down.


This addresses bug HBASE-4450.
    https://issues.apache.org/jira/browse/HBASE-4450


Diffs
-----

  
https://svn.apache.org/repos/asf/hbase/trunk/src/test/java/org/apache/hadoop/hbase/regionserver/TestBlocksRead.java
 PRE-CREATION 

Diff: https://reviews.apache.org/r/1998/diff


Testing
-------


Thanks,

Kannan



> test for number of blocks read: to serve as baseline for expected blocks read 
> and for catching regressions
> ----------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-4450
>                 URL: https://issues.apache.org/jira/browse/HBASE-4450
>             Project: HBase
>          Issue Type: Test
>            Reporter: Kannan Muthukkaruppan
>            Assignee: Kannan Muthukkaruppan
>
> Add a simple test for number of blocks read. The tests intent is to serve as 
> baseline for expected blocks read and for catching regressions. As 
> optimizations for HBase-4433 or Hbase-4434 are committed, the test would need 
> to be updated to adjust the counts for expected blocks read in various cases.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to