[ 
https://issues.apache.org/jira/browse/HBASE-5954?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14299445#comment-14299445
 ] 

stack commented on HBASE-5954:
------------------------------

I took a look at that patch. LGTM.  This stuff is hard to review. It is tricky. 
 Proof is in the pudding.  For sure the failure is unrelated? Its in the WAL?  
I'm +1 on commit.  Suggest try hadoopqa a few more times before commit.

> Allow proper fsync support for HBase
> ------------------------------------
>
>                 Key: HBASE-5954
>                 URL: https://issues.apache.org/jira/browse/HBASE-5954
>             Project: HBase
>          Issue Type: Improvement
>          Components: HFile, wal
>            Reporter: Lars Hofhansl
>            Assignee: Lars Hofhansl
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: 5954-WIP-trunk.txt, 5954-WIP-v2-trunk.txt, 
> 5954-trunk-hdfs-trunk-v2.txt, 5954-trunk-hdfs-trunk-v3.txt, 
> 5954-trunk-hdfs-trunk-v4.txt, 5954-trunk-hdfs-trunk-v5.txt, 
> 5954-trunk-hdfs-trunk-v6.txt, 5954-trunk-hdfs-trunk.txt, 5954-v3-trunk.txt, 
> 5954-v3-trunk.txt, 5954-v4-trunk.txt, 5954-v5-trunk.txt, hbase-hdfs-744.txt
>
>
> At least get recommendation into 0.96 doc and some numbers running w/ this 
> hdfs feature enabled.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to