[
https://issues.apache.org/jira/browse/HBASE-12992?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14314000#comment-14314000
]
Andrey Stepachev commented on HBASE-12992:
------------------------------------------
Hi, [~dimaspivak], thank you for looking at this patch.
As for change made, printed stacktrace generates useless stdout exceptions.
Such exceptions occur when service is shut down and with number of SlowChore
instances we have high probability to see this stdout.
(in can be removed from initialChore too, but interruption in that place is
quite unusual and so can be informative).
Sure, we have an option to make that LOG.info/debug/error
If you have a good reason to have that on stdout and when that can help to
catch error or so, please share. Even better we can teach SlowChore to record
fact of interruption and check somewhere later.
> TestChoreService doesn't close services, that can break test on slow virtual
> hosts.
> -----------------------------------------------------------------------------------
>
> Key: HBASE-12992
> URL: https://issues.apache.org/jira/browse/HBASE-12992
> Project: HBase
> Issue Type: Test
> Affects Versions: 2.0.0
> Reporter: Andrey Stepachev
> Assignee: Andrey Stepachev
> Fix For: 2.0.0, 1.1.0
>
> Attachments: HBASE-12992.patch, HBASE-12992.patch
>
>
> On my slow virtual machine it quite possible to fail this test due of
> enormous amount of active threads to the end of test.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
