[ 
https://issues.apache.org/jira/browse/HBASE-12585?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14315561#comment-14315561
 ] 

Hadoop QA commented on HBASE-12585:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12697946/HBASE-12585-v1.patch
  against master branch at commit 9c66afbae752b06b058df34c0e40fbbf54426ac3.
  ATTACHMENT ID: 12697946

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+0 tests included{color}.  The patch appears to be a 
documentation patch that doesn't require tests.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:red}-1 javadoc{color}.  The javadoc tool appears to have generated 1 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +For more information about how connections are handled in the HBase 
client, see 
link:http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/ConnectionFactory.html[ConnectionFactory].
+For applications which require high-end multithreaded access (e.g., 
web-servers or application servers that may serve many application threads in a 
single JVM), you can pre-create a `Connection`, as shown in the following 
example:
+Previous versions of this guide discussed `HTablePool`, which was deprecated 
in HBase 0.94, 0.95, and 0.96, and removed in 0.98.1, by 
link:https://issues.apache.org/jira/browse/HBASE-6580[HBASE-6500], or 
`HConnection`, which is deprecated in HBase 1.0 by `Connection`.
+Please use 
link:http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Connection.html[Connection]
 instead.
+In HBase 1.0 and later, 
link:http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HTable.html[HTable]
 is deprecated in favor of 
link:http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Table.html[Table].
 `Table` does not use autoflush. To do buffered writes, use the BufferedMutator 
class.
+Prior to HBase 1.0, if you are using 
link:http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/HTable.html[HTable]
 and  <<perf.hbase.client.autoflush>> is turned off , ``Put``s are sent to 
RegionServers when the writebuffer is filled.
+Before a `Table` or `HTable` instance is discarded, invoke either `close()` or 
`flushCommits()`, so `Put`s will not be lost.
+For fine-grained control of batching of ``Put``s or ``Delete``s, see the 
link:http://hbase.apache.org/apidocs/org/apache/hadoop/hbase/client/Table.html#batch%28java.util.List%29[batch]
 methods on Table.
+* Region (move, assign, unassign) For example, when the `Admin` method 
`disableTable` is invoked, it is serviced by the Master server.
+* Region (splitRegion, compactRegion, etc.) For example, when the `Admin` 
method `majorCompact` is invoked on a table, the client is actually iterating 
through all regions for the specified table and requesting a major compaction 
directly to each region.

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
                       
org.apache.hadoop.hbase.mapreduce.TestLoadIncrementalHFiles

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/checkstyle-aggregate.html

  Javadoc warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//artifact/patchprocess/patchJavadocWarnings.txt
Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12772//console

This message is automatically generated.

> Fix refguide so it does hbase 1.0 style API everywhere with callout on how we 
> used to do it in pre-1.0
> ------------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-12585
>                 URL: https://issues.apache.org/jira/browse/HBASE-12585
>             Project: HBase
>          Issue Type: Bug
>          Components: documentation
>            Reporter: stack
>            Assignee: Misty Stanley-Jones
>             Fix For: 1.0.1, 1.1.0
>
>         Attachments: HBASE-12585-v1.patch, HBASE-12585.patch
>
>
> Over in HBASE-12400, made a start on this project writing up how the new 
> HBase 1.0 API looks.  I started in on the refguide removing all HTable 
> references replacing with new style and in the hbase client chapter added 
> leadoff that has users go get a cluster Connection first....
> Doing a thorough job of rinsing the doc of old style foregrounding the new 
> mode is a big job.
> [~misty] Any chance of help on this one?  Thanks boss.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to