[ 
https://issues.apache.org/jira/browse/HBASE-4131?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113023#comment-13113023
 ] 

stack commented on HBASE-4131:
------------------------------

nit: Have replication constants in the replication package rather than up in 
HConstants (do they need to be there?)

nit: Looks like you are importing a bunch of crud you are not using in 
Interfaces at least.

nit: Do you need to pass the filesystem on initialize of ReplicationService?  
You can do:

FileSystem fs = FileSystem.get(server.getConfiguration());

Else +1 on patch if tests pass (Above nits can be fixed on commit)

> Make the Replication Service pluggable via a standard interface definition
> --------------------------------------------------------------------------
>
>                 Key: HBASE-4131
>                 URL: https://issues.apache.org/jira/browse/HBASE-4131
>             Project: HBase
>          Issue Type: Improvement
>          Components: regionserver
>            Reporter: dhruba borthakur
>            Assignee: dhruba borthakur
>         Attachments: replicationInterface1.txt, replicationInterface2.txt
>
>
> The current HBase code supports a replication service that can be used to 
> sync data from from one hbase cluster to another. It would be nice to make it 
> a pluggable interface so that other cross-data-center replication services 
> can be used in conjuction with HBase.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to