[ 
https://issues.apache.org/jira/browse/HBASE-13018?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14317107#comment-14317107
 ] 

stack commented on HBASE-13018:
-------------------------------

+1

[~octo47] Going forward, add braces when if is more than one line.  This is 
fine...

if (x) y = 0;

We don't do this in our codebase:

if (x)
  y = 0;

Nice patch otherwise.

> WALSplitter should not try to get table states while splitting META
> -------------------------------------------------------------------
>
>                 Key: HBASE-13018
>                 URL: https://issues.apache.org/jira/browse/HBASE-13018
>             Project: HBase
>          Issue Type: Improvement
>    Affects Versions: 2.0.0
>            Reporter: Andrey Stepachev
>            Assignee: Andrey Stepachev
>            Priority: Critical
>             Fix For: 2.0.0
>
>         Attachments: HBASE-13018.patch
>
>
> org.apache.hadoop.hbase.wal.WALSplitter#splitLogFile(org.apache.hadoop.fs.FileStatus,
>  org.apache.hadoop.hbase.util.CancelableProgressable) gathering disabled 
> tables and tries to access META. If given splitter splits meta it obviously 
> will hang trying to get meta.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to