[
https://issues.apache.org/jira/browse/HBASE-13026?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14318181#comment-14318181
]
Hadoop QA commented on HBASE-13026:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698396/0001-HBASE-13026-Wrong-error-message-in-case-incorrect-sn.patch
against master branch at commit b7f6a45803d6b56a2ff56ebcac6a78aee100b409.
ATTACHMENT ID: 12698396
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1937 checkstyle errors (more than the master's current 1936 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
{color:red}-1 core zombie tests{color}. There are 2 zombie test(s):
at
org.apache.sling.installer.provider.jcr.impl.FolderDetectionTest.testMoveLibsToFoo(FolderDetectionTest.java:58)
at
org.apache.hadoop.hbase.coprocessor.TestMasterObserver.testRegionTransitionOperations(TestMasterObserver.java:1604)
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12796//console
This message is automatically generated.
> Wrong error message in case incorrect snapshot name OR Incorrect table name
> ---------------------------------------------------------------------------
>
> Key: HBASE-13026
> URL: https://issues.apache.org/jira/browse/HBASE-13026
> Project: HBase
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Bhupendra Kumar Jain
> Priority: Minor
> Attachments:
> 0001-HBASE-13026-Wrong-error-message-in-case-incorrect-sn.patch
>
>
> hbase(main):009:0> snapshot 't1', '.t1Snapshot'
> ERROR: Illegal first character <46> at 0. {color:red}*Namespaces*{color} can
> only start with alphanumeric characters': i.e. [a-zA-Z_0-9]: t1Snapshot
> hbase(main):008:0> create '-test' , 'cf1'
> ERROR: Illegal first character <45> at 0.{color:red}*Namespaces*{color} can
> only start with alphanumeric characters': i.e. [a-zA-Z_0-9]: -test
> >> As per message "Namespaces" is wrong. But in this scenario, snapshot /
> >> table name start character is wrong.
> Its because in the code the message is as below
> {code}
> if (qualifierName[start] == '.' || qualifierName[start] == '-') {
> throw new IllegalArgumentException("Illegal first character <" +
> qualifierName[0] +
> "> at 0. Namespaces can only start
> with alphanumeric " +
> "characters': i.e. [a-zA-Z_0-9]: " +
> Bytes.toString(qualifierName));
> {code}
> The correct code should be as below
> {code}
> if (qualifierName[start] == '.' || qualifierName[start] == '-') {
> throw new IllegalArgumentException("Illegal first character <" +
> qualifierName[start] +
> "> at 0. " + (isSnapshot ?
> "Snapshot" : "User-space table") +
> " qualifiers can only start with
> 'alphanumeric " +
> "characters': i.e. [a-zA-Z_0-9]: " +
> Bytes.toString(qualifierName, start,
> end));
> {code}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
