[
https://issues.apache.org/jira/browse/HBASE-12102?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320111#comment-14320111
]
Hadoop QA commented on HBASE-12102:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698705/HBASE-12102.patch
against master branch at commit 7561ae6d1257b51c0bb1ef46e52d8ede2c7c926f.
ATTACHMENT ID: 12698705
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:red}-1 tests included{color}. The patch doesn't appear to include
any new or modified tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:red}-1 javadoc{color}. The javadoc tool appears to have generated 1
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/checkstyle-aggregate.html
Javadoc warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//artifact/patchprocess/patchJavadocWarnings.txt
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12823//console
This message is automatically generated.
> Duplicate keys in HBase.RegionServer metrics JSON
> -------------------------------------------------
>
> Key: HBASE-12102
> URL: https://issues.apache.org/jira/browse/HBASE-12102
> Project: HBase
> Issue Type: Bug
> Affects Versions: 1.0.0, 2.0.0, 0.98.10
> Reporter: Andrew Purtell
> Assignee: Ravi Kishore Valeti
> Priority: Minor
> Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11
>
> Attachments: HBASE-12102-0.98.patch, HBASE-12102.patch
>
>
> The JSON returned by /jmx on the RegionServer contains duplicate
> 'tag.Context' keys for various HBase.RegionServer metrics.
> Regions:
> {noformat}
> {
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Regions",
> "modelerType" : "RegionServer,sub=Regions",
> "tag.Context" : "regionserver",
> "tag.Context" : "regionserver",
> "tag.Hostname" : "some.host.name",
> ...
> }
> {noformat}
> Server:
> {noformat}
> "name" : "Hadoop:service=HBase,name=RegionServer,sub=Server",
> "modelerType" : "RegionServer,sub=Server",
> "tag.Context" : "regionserver",
> "tag.zookeeperQuorum" : "some.zookeeper.quorum.peers",
> "tag.serverName" : "some.server.name",
> "tag.clusterId" : "88c186ea-2308-4713-8b5f-5a3e829cbb10",
> "tag.Context" : "regionserver",
> ...
> }
> {noformat}
> IPC:
> {noformat}
> {
> "name" : "Hadoop:service=HBase,name=IPC,sub=IPC",
> "modelerType" : "IPC,sub=IPC",
> "tag.Context" : "ipc",
> "tag.Context" : "ipc",
> "tag.Hostname" : "some.host.name",
> ...
> }
> {noformat}
> This can cause issues with some JSON parsers. We should avoid emitting
> duplicate keys if it is under our control.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
