[ 
https://issues.apache.org/jira/browse/HBASE-13030?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14320502#comment-14320502
 ] 

Hadoop QA commented on HBASE-13030:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12698776/13030v7.txt
  against master branch at commit cfc131e4379b3ac4c9de83e63dda41ce4df01e22.
  ATTACHMENT ID: 12698776

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 9 new 
or modified tests.

    {color:red}-1 patch{color}.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12833//console

This message is automatically generated.

> [1.0.0 polish] Make ScanMetrics public again and align Put 'add' with Get, 
> Delete, etc., addColumn
> --------------------------------------------------------------------------------------------------
>
>                 Key: HBASE-13030
>                 URL: https://issues.apache.org/jira/browse/HBASE-13030
>             Project: HBase
>          Issue Type: Bug
>          Components: Operability
>    Affects Versions: 1.0.0
>            Reporter: stack
>            Assignee: stack
>             Fix For: 1.0.0, 2.0.0, 1.1.0
>
>         Attachments: 13030.txt, 13030v2.txt, 13030v3.txt, 13030v5.txt, 
> 13030v7.txt, hbase-13030-scanmetrics.patch, hbase-13030-v6.patch
>
>
> These are some of the items raised by [~larsgeorge] looking at our API for 
> first time in a long time trying to update examples in the HBase Book.
> 1. ScanMetrics used to be available with some gymnastics in old days. Now it 
> is IA.private and to get at it from Scan context, you need to use private 
> ProtobufUtils. This seems like useful advanced user utility that should not 
> be shut down.
> 2. Put is not like the others around the addColumn usage. Fix.
> [~enis] Hopefully these ok to go in (the Scan class addition is a little ugly 
> but didn't want to do anything more adventurous this late in the game).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to