[ 
https://issues.apache.org/jira/browse/HBASE-13002?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321168#comment-14321168
 ] 

Andrew Purtell commented on HBASE-13002:
----------------------------------------

bq.  I have added the logic in Encrption#decryptWithSubjectKey for decrypt api 
but not where we already have fallback logic for master key

Ok

{quote}
Also while going through the code I found that we are using 
{{hbase.crypto.wal.algorithm}} in {{SecureProtobufLogWriter}} for encrypting 
the data but we are using {{hbase.crypto.key.algorithm}} in 
{{SecureProtobufLogReader}} while decrypting the data. What if user configures 
two different cipher algorithms to this configurations ? Is this intentional ?
{quote}

That is a typo, let's fix it. 

> Make encryption cipher configurable
> -----------------------------------
>
>                 Key: HBASE-13002
>                 URL: https://issues.apache.org/jira/browse/HBASE-13002
>             Project: HBase
>          Issue Type: Improvement
>            Reporter: Ashish Singhi
>            Assignee: Ashish Singhi
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11
>
>         Attachments: HBASE-13002-v1.patch, HBASE-13002-v2.patch, 
> HBASE-13002.patch
>
>
> Make encryption cipher configurable currently it is hard coded to AES, so 
> that user can configure his/her own algorithm.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to