[ 
https://issues.apache.org/jira/browse/HBASE-13040?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321193#comment-14321193
 ] 

zhangduo commented on HBASE-13040:
----------------------------------

0.98 does not have this problem. On 0.98 we need to call HMaster.run to start 
service so the testcase is safe.

And on branch-1, I found this in log when running the test

{noformat}
2015-02-14 10:47:44,734 FATAL [zhangduo-ubuntu:44957.activeMasterManager] 
master.HMaster$1(1474): Failed to become active master
java.lang.IllegalArgumentException: Illegal character <10> at 0. Namespaces can 
only contain 'alphanumeric characters': i.e. [a-zA-Z_0-9]: 
hbasemeta
        at 
org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:216)
        at 
org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:205)
        at org.apache.hadoop.hbase.TableName.<init>(TableName.java:308)
        at 
org.apache.hadoop.hbase.TableName.createTableNameIfNecessary(TableName.java:345)
        at org.apache.hadoop.hbase.TableName.valueOf(TableName.java:466)
        at 
org.apache.hadoop.hbase.protobuf.ProtobufUtil.toTableName(ProtobufUtil.java:2692)
        at 
org.apache.hadoop.hbase.HTableDescriptor.convert(HTableDescriptor.java:1557)
        at 
org.apache.hadoop.hbase.HTableDescriptor.parseFrom(HTableDescriptor.java:1518)
        at 
org.apache.hadoop.hbase.util.FSTableDescriptors.readTableDescriptor(FSTableDescriptors.java:526)
        at 
org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptorForTableDirectory(FSTableDescriptors.java:730)
        at 
org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptor(FSTableDescriptors.java:706)
        at 
org.apache.hadoop.hbase.util.FSTableDescriptors.createTableDescriptor(FSTableDescriptors.java:693)
        at 
org.apache.hadoop.hbase.master.MasterFileSystem.checkRootDir(MasterFileSystem.java:471)
        at 
org.apache.hadoop.hbase.master.MasterFileSystem.createInitialFileSystemLayout(MasterFileSystem.java:145)
        at 
org.apache.hadoop.hbase.master.MasterFileSystem.<init>(MasterFileSystem.java:125)
        at 
org.apache.hadoop.hbase.master.HMaster.finishActiveMasterInitialization(HMaster.java:594)
        at org.apache.hadoop.hbase.master.HMaster.access$3(HMaster.java:577)
        at org.apache.hadoop.hbase.master.HMaster$1.run(HMaster.java:1470)
        at java.lang.Thread.run(Thread.java:745)
{noformat}
So HMaster can not finish initialization and the test is safe too.

> Possible failure of TestHMasterRPCException
> -------------------------------------------
>
>                 Key: HBASE-13040
>                 URL: https://issues.apache.org/jira/browse/HBASE-13040
>             Project: HBase
>          Issue Type: Bug
>          Components: test
>    Affects Versions: 2.0.0
>            Reporter: zhangduo
>            Assignee: zhangduo
>         Attachments: HBASE-13040.patch
>
>
> When addressing HBASE-13011, TestHMasterRPCException failed twice in 
> PreCommit Build.
> I found that the test itself has a problem. We start a HMaster, and then we 
> continue calling isMasterRunning and expected a ServerNotRunningYetException.
> But it is possible that when we connect to HMaster, it has already finished 
> initialization, and we just get a 'true' response instead of an 
> Exception.(Just add a 'Thread.sleep(1000);' after 'HMaster hm = new 
> HMaster(conf, cp);', you can get a stable failure).



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to