[
https://issues.apache.org/jira/browse/HBASE-13028?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14321301#comment-14321301
]
Hadoop QA commented on HBASE-13028:
-----------------------------------
{color:green}+1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12698891/HBASE-13028.3.patch.txt
against master branch at commit 6f904fe4caa026d4e0d050d97b2d8a1be6ca0785.
ATTACHMENT ID: 12698891
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 8 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:green}+1 checkstyle{color}. The applied patch does not increase the
total number of checkstyle errors
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:green}+1 core tests{color}. The patch passed unit tests in .
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12852//console
This message is automatically generated.
> Cleanup mapreduce API changes
> -----------------------------
>
> Key: HBASE-13028
> URL: https://issues.apache.org/jira/browse/HBASE-13028
> Project: HBase
> Issue Type: Bug
> Components: mapreduce
> Affects Versions: 1.0.0
> Reporter: Sean Busbey
> Assignee: Sean Busbey
> Priority: Blocker
> Labels: api
> Fix For: 1.0.0, 2.0.0
>
> Attachments: HBASE-13028.1.patch.txt, HBASE-13028.2.patch.txt,
> HBASE-13028.3.patch.txt
>
>
> The API changes made in HBASE-12798 need to be cleaned up so their common use
> makes more sense.
> * initialize should take some kind of configuration object that can be used
> in setting up a Connection (e.g. JobConf)
> * initialize should be called at the start of getSplits and getRecordReader
> rather than across the class when a member is needed
> * the same changes should be present in the mapred package since it is not
> longer deprecated
> * examples should rely on idiomatic MapReduce (specifically they should not
> be relying on JobConfigurable to get a JobConf instance)
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
