[
https://issues.apache.org/jira/browse/HBASE-13050?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14324043#comment-14324043
]
Hadoop QA commented on HBASE-13050:
-----------------------------------
{color:red}-1 overall{color}. Here are the results of testing the latest
attachment
http://issues.apache.org/jira/secure/attachment/12699225/0001-HBASE-13050-Empty-Namespace-name-validation.patch
against master branch at commit bfc2bc7fa2101eafa8fd63a86223e1a15f74d434.
ATTACHMENT ID: 12699225
{color:green}+1 @author{color}. The patch does not contain any @author
tags.
{color:green}+1 tests included{color}. The patch appears to include 4 new
or modified tests.
{color:green}+1 hadoop versions{color}. The patch compiles with all
supported hadoop versions (2.4.1 2.5.2 2.6.0)
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javac{color}. The applied patch does not increase the
total number of javac compiler warnings.
{color:green}+1 javadoc{color}. The javadoc tool did not generate any
warning messages.
{color:red}-1 checkstyle{color}. The applied patch generated
1936 checkstyle errors (more than the master's current 1935 errors).
{color:green}+1 findbugs{color}. The patch does not introduce any new
Findbugs (version 2.0.3) warnings.
{color:green}+1 release audit{color}. The applied patch does not increase
the total number of release audit warnings.
{color:green}+1 lineLengths{color}. The patch does not introduce lines
longer than 100
{color:green}+1 site{color}. The mvn site goal succeeds with this patch.
{color:red}-1 core tests{color}. The patch failed these unit tests:
org.apache.hadoop.hbase.mapreduce.TestMultithreadedTableMapper
Test results:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Checkstyle Errors:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//artifact/patchprocess/checkstyle-aggregate.html
Console output:
https://builds.apache.org/job/PreCommit-HBASE-Build/12876//console
This message is automatically generated.
> Hbase shell create_namespace command throws ArrayIndexOutOfBoundException for
> (invalid) empty text input.
> ---------------------------------------------------------------------------------------------------------
>
> Key: HBASE-13050
> URL: https://issues.apache.org/jira/browse/HBASE-13050
> Project: HBase
> Issue Type: Bug
> Reporter: Abhishek Kumar
> Priority: Trivial
> Attachments: 0001-HBASE-13050-Empty-Namespace-name-validation.patch
>
>
> {noformat}
> hbase(main):008:0> create_namespace ''
> ERROR: java.io.IOException: 0
> at org.apache.hadoop.hbase.ipc.RpcServer.call(RpcServer.java:2072)
> at org.apache.hadoop.hbase.ipc.CallRunner.run(CallRunner.java:107)
> at
> org.apache.hadoop.hbase.ipc.RpcExecutor.consumerLoop(RpcExecutor.java:130)
> at org.apache.hadoop.hbase.ipc.RpcExecutor$1.run(RpcExecutor.java:107)
> at java.lang.Thread.run(Thread.java:745)
> Caused by: java.lang.ArrayIndexOutOfBoundsException: 0
> at
> org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:222)
> at
> org.apache.hadoop.hbase.TableName.isLegalNamespaceName(TableName.java:205)
> {noformat}
> TableName.isLegalNamespaceName tries to access namespaceName[offset] in case
> of empty text input and also this check for 'offset==length' in this method
> seems to be unnecessary and an empty input validation check can be put in
> the beginning of this method instead:
> {noformat}
> public static void isLegalNamespaceName(byte[] namespaceName, int offset,
> int length) {
> // can add empty check in the beginning
> if(length == 0) {
> throw new IllegalArgumentException("Namespace name must not be empty");
> }
> // end
> for (int i = offset; i < length; i++) {
> if (Character.isLetterOrDigit(namespaceName[i])|| namespaceName[i] ==
> '_') {
> continue;
> }
> throw new IllegalArgumentException("Illegal character <" +
> namespaceName[i] +
> "> at " + i + ". Namespaces can only contain " +
> "'alphanumeric characters': i.e. [a-zA-Z_0-9]: " +
> Bytes.toString(namespaceName,
> offset, length));
> }
> // can remove below check
> if(offset == length)
> throw new IllegalArgumentException("Illegal character <" +
> _namespaceName[offset] _+
> "> at " + offset + ". Namespaces can only contain " +
> "'alphanumeric characters': i.e. [a-zA-Z_0-9]: " +
> Bytes.toString(namespaceName,
> offset, length));
> //
> }
> {noformat}
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
