[
https://issues.apache.org/jira/browse/HBASE-4209?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13113616#comment-13113616
]
stack commented on HBASE-4209:
------------------------------
This is not good:
{code}
+ } catch (Throwable ex) {}
{code}
At least log the exception.
And similar here:
{code}
+ try {
+ HRegionServer.startRegionServer(t.getRegionServer());
+ } catch (Throwable ex) {}
+ // t.start();
{code}
What is the exception we are suppressing? Should we at least log it here too?
Otherwise, I'm fine with this referencecounting stuff. Its contained to the
shutdown handler class.
Good stuff.
> The HBase hbase-daemon.sh SIGKILLs master when stopping it
> ----------------------------------------------------------
>
> Key: HBASE-4209
> URL: https://issues.apache.org/jira/browse/HBASE-4209
> Project: HBase
> Issue Type: Bug
> Components: master
> Reporter: Roman Shaposhnik
> Assignee: Roman Shaposhnik
> Attachments: HBASE-4209.patch.txt
>
>
> There's a bit of code in hbase-daemon.sh that makes HBase master being
> SIGKILLed when stopping it rather than trying SIGTERM (like it does for other
> daemons). When HBase is executed in a standalone mode (and the only daemon
> you need to run is master) that causes newly created tables to go missing as
> unflushed data is thrown out. If there was not a good reason to kill master
> with SIGKILL perhaps we can take that special case out and rely on SIGTERM.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
