[
https://issues.apache.org/jira/browse/HBASE-13048?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14333855#comment-14333855
]
Srikanth Srungarapu commented on HBASE-13048:
---------------------------------------------
patch looks good to me.
* nit: not really required, unless you want to add more description.
{code}
+ * @throws IOException
+ * @throws KeyException
{code}
* nit: May be you can move the unwrapping with incorrect key to separate test
and apply the following annotation *only* to it.
{code}
+ @Test(expected = KeyException.class)
{code}
> Use hbase.crypto.wal.algorithm in SecureProtobufLogReader while decrypting
> the data
> -----------------------------------------------------------------------------------
>
> Key: HBASE-13048
> URL: https://issues.apache.org/jira/browse/HBASE-13048
> Project: HBase
> Issue Type: Bug
> Affects Versions: 0.98.10
> Reporter: Ashish Singhi
> Assignee: Ashish Singhi
> Priority: Minor
> Attachments: HBASE-13048.patch
>
>
> We are using {{hbase.crypto.wal.algorithm}} in {{SecureProtobufLogWriter}}
> for encrypting the data but we are using not using the same algorithm in
> {{SecureProtobufLogReader}} while decrypting the data, fix this typo.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)
