[ 
https://issues.apache.org/jira/browse/HBASE-13106?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14337758#comment-14337758
 ] 

Hadoop QA commented on HBASE-13106:
-----------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest 
attachment 
  http://issues.apache.org/jira/secure/attachment/12700920/HBASE-13106.patch
  against master branch at commit 7195f62114ce68dfa94115443d2b27cd2d7df01c.
  ATTACHMENT ID: 12700920

    {color:green}+1 @author{color}.  The patch does not contain any @author 
tags.

    {color:green}+1 tests included{color}.  The patch appears to include 8 new 
or modified tests.
    {color:green}+1 hadoop versions{color}. The patch compiles with all 
supported hadoop versions (2.4.1 2.5.2 2.6.0)

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javac{color}.  The applied patch does not increase the 
total number of javac compiler warnings.

    {color:green}+1 javadoc{color}.  The javadoc tool did not generate any 
warning messages.

    {color:green}+1 checkstyle{color}.  The applied patch does not increase the 
total number of checkstyle errors

    {color:green}+1 findbugs{color}.  The patch does not introduce any new 
Findbugs (version 2.0.3) warnings.

    {color:green}+1 release audit{color}.  The applied patch does not increase 
the total number of release audit warnings.

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines 
longer than 100:
    +    
desc.addCoprocessor(org.apache.hadoop.hbase.coprocessor.ColumnAggregationEndpoint.class.getName());
+    
desc.addCoprocessor(org.apache.hadoop.hbase.coprocessor.ColumnAggregationEndpoint.class.getName());

  {color:green}+1 site{color}.  The mvn site goal succeeds with this patch.

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     

     {color:red}-1 core zombie tests{color}.  There are 2 zombie test(s):       
at 
org.apache.hadoop.hbase.coprocessor.TestMasterObserver.testRegionTransitionOperations(TestMasterObserver.java:1604)
        at 
org.apache.curator.test.TestingZooKeeperMain.runFromConfig(TestingZooKeeperMain.java:73)
        at 
org.apache.curator.test.TestingZooKeeperServer$1.run(TestingZooKeeperServer.java:148)
        at org.apache.curator.test.Timing.sleepABit(Timing.java:199)
        at 
org.apache.hadoop.util.curator.TestChildReaper.testSimple(TestChildReaper.java:120)

Test results: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//testReport/
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/newPatchFindbugsWarningshbase-examples.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/newPatchFindbugsWarningshbase-prefix-tree.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/newPatchFindbugsWarningshbase-server.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/newPatchFindbugsWarningshbase-client.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/newPatchFindbugsWarningshbase-protocol.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/newPatchFindbugsWarningshbase-hadoop2-compat.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/newPatchFindbugsWarningshbase-rest.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/newPatchFindbugsWarningshbase-thrift.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/newPatchFindbugsWarningshbase-annotations.html
Findbugs warnings: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/newPatchFindbugsWarningshbase-common.html
Checkstyle Errors: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//artifact/patchprocess/checkstyle-aggregate.html

  Console output: 
https://builds.apache.org/job/PreCommit-HBASE-Build/12971//console

This message is automatically generated.

> Ensure endpoint-only table coprocessors can be dynamically loaded
> -----------------------------------------------------------------
>
>                 Key: HBASE-13106
>                 URL: https://issues.apache.org/jira/browse/HBASE-13106
>             Project: HBase
>          Issue Type: Test
>            Reporter: Andrew Purtell
>            Assignee: Andrew Purtell
>            Priority: Trivial
>             Fix For: 2.0.0, 1.0.1, 1.1.0, 0.98.11
>
>         Attachments: HBASE-13106.patch, HBASE-13106.patch
>
>
> I came across the blog post 
> http://www.3pillarglobal.com/insights/hbase-coprocessors and this interesting 
> bit:
> {quote}
> This means that you can load both Observer and Endpoint Coprocessor 
> statically using the following Method of HTableDescriptor:
> {noformat}
> addCoprocessor(String className, org.apache.hadoop.fs.Path jarFilePath, int 
> priority, Map<String,String> kvs) throws IOException
> {noformat}
> In my case, the above method worked fine for Observer Coprocessor *but didn’t 
> work for Endpoint Coprocessor, causing the table to become unavailable and 
> finally I had to restart my HBase*. The same Endpoint Coprocessor worked fine 
> when loaded statically. Use the above method for Endpoint Coprocessor with 
> caution.
> {quote}
> To check this I wrote a test, attached. It passes, all seems ok. Guessing the 
> complaint was due to user error, probably jar placement/path issues.
> Let's still commit the test.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Reply via email to